From d94db78aecff47ac4af8bb5fa4a28f258bab8997 Mon Sep 17 00:00:00 2001
From: Martin Porwoll <martin.porwoll@complexcaresolutions.de>
Date: Fri, 13 Feb 2026 22:24:12 +0000
Subject: [PATCH] fix: resolve all ESLint errors for clean CI pipeline

- Extend admin component overrides to cover all Payload admin views
  (no-html-link-for-pages, no-img-element off for admin panel)
- Rename useGeneratedReply to applyGeneratedReply (not a hook)
- Fix useRealtimeUpdates: resolve circular dependency with connectRef,
  wrap ref assignments in useEffect for React 19 compiler compliance
- Fix MetaBaseClient: let -> const for single-assignment variable

ESLint now passes with 0 errors (68 warnings only).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 eslint.config.mjs                             |  5 +-
 .../views/community/inbox/CommunityInbox.tsx  |  4 +-
 src/hooks/useRealtimeUpdates.ts               | 46 +++++++++++--------
 src/lib/integrations/meta/MetaBaseClient.ts   |  2 +-
 4 files changed, 34 insertions(+), 23 deletions(-)

diff --git a/eslint.config.mjs b/eslint.config.mjs
index 0541cf6..d7b2a88 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -25,10 +25,11 @@ const eslintConfig = [
     },
   },
   {
-    // Payload Admin components can use <a> elements (they're not in Next.js page router)
-    files: ['src/components/admin/**/*.tsx'],
+    // Payload Admin components can use <a> and <img> elements (they're not in Next.js page router)
+    files: ['src/components/admin/**/*.tsx', 'src/app/(payload)/admin/**/*.tsx'],
     rules: {
       '@next/next/no-html-link-for-pages': 'off',
+      '@next/next/no-img-element': 'off',
     },
   },
   {
diff --git a/src/app/(payload)/admin/views/community/inbox/CommunityInbox.tsx b/src/app/(payload)/admin/views/community/inbox/CommunityInbox.tsx
index 7f687b4..9017d50 100644
--- a/src/app/(payload)/admin/views/community/inbox/CommunityInbox.tsx
+++ b/src/app/(payload)/admin/views/community/inbox/CommunityInbox.tsx
@@ -469,7 +469,7 @@ export const CommunityInbox: React.FC = () => {
   }
 
   // Use generated reply
-  const useGeneratedReply = (reply: { text: string }) => {
+  const applyGeneratedReply = (reply: { text: string }) => {
     setReplyText(reply.text)
     setGeneratedReplies([])
   }
@@ -1518,7 +1518,7 @@ export const CommunityInbox: React.FC = () => {
                               )}
                               <button
                                 className="btn btn-use-suggestion"
-                                onClick={() => useGeneratedReply(reply)}
+                                onClick={() => applyGeneratedReply(reply)}
                               >
                                 Übernehmen
                               </button>
diff --git a/src/hooks/useRealtimeUpdates.ts b/src/hooks/useRealtimeUpdates.ts
index c344194..a565995 100644
--- a/src/hooks/useRealtimeUpdates.ts
+++ b/src/hooks/useRealtimeUpdates.ts
@@ -94,12 +94,29 @@ export function useRealtimeUpdates(
   const eventSourceRef = useRef<EventSource | null>(null)
   const reconnectTimeoutRef = useRef<NodeJS.Timeout | null>(null)
   const lastTimestampRef = useRef<string | null>(null)
+  const connectRef = useRef<() => void>(() => {})
 
   // Callbacks als Refs speichern um Dependency-Probleme zu vermeiden
   const onUpdateRef = useRef(onUpdate)
   const onConnectionChangeRef = useRef(onConnectionChange)
-  onUpdateRef.current = onUpdate
-  onConnectionChangeRef.current = onConnectionChange
+  useEffect(() => {
+    onUpdateRef.current = onUpdate
+    onConnectionChangeRef.current = onConnectionChange
+  })
+
+  /**
+   * Reconnect nach Verzögerung planen
+   */
+  const scheduleReconnect = useCallback(() => {
+    if (reconnectTimeoutRef.current) {
+      return // Bereits geplant
+    }
+
+    reconnectTimeoutRef.current = setTimeout(() => {
+      reconnectTimeoutRef.current = null
+      connectRef.current()
+    }, 3000) // 3 Sekunden warten
+  }, [])
 
   /**
    * Verbindung herstellen
@@ -205,7 +222,12 @@ export function useRealtimeUpdates(
       setConnecting(false)
       setError('Failed to connect')
     }
-  }, [channelIds, connecting, maxUpdates])
+  }, [channelIds, connecting, maxUpdates, scheduleReconnect])
+
+  // Keep ref in sync so scheduleReconnect can call latest connect
+  useEffect(() => {
+    connectRef.current = connect
+  })
 
   /**
    * Verbindung trennen
@@ -226,20 +248,6 @@ export function useRealtimeUpdates(
     onConnectionChangeRef.current?.(false)
   }, [])
 
-  /**
-   * Reconnect nach Verzögerung planen
-   */
-  const scheduleReconnect = useCallback(() => {
-    if (reconnectTimeoutRef.current) {
-      return // Bereits geplant
-    }
-
-    reconnectTimeoutRef.current = setTimeout(() => {
-      reconnectTimeoutRef.current = null
-      connect()
-    }, 3000) // 3 Sekunden warten
-  }, [connect])
-
   /**
    * Updates zurücksetzen
    */
@@ -254,9 +262,10 @@ export function useRealtimeUpdates(
     setNewCount(0)
   }, [])
 
-  // Auto-Connect beim Mount
+  // Auto-Connect beim Mount (SSE external system subscription)
   useEffect(() => {
     if (autoConnect) {
+      // eslint-disable-next-line react-hooks/set-state-in-effect -- SSE subscription pattern
       connect()
     }
 
@@ -268,6 +277,7 @@ export function useRealtimeUpdates(
   // Channel-IDs Änderung: Reconnect
   useEffect(() => {
     if (connected || connecting) {
+      // eslint-disable-next-line react-hooks/set-state-in-effect -- SSE reconnect pattern
       disconnect()
       // Kurz warten, dann neu verbinden
       const timeout = setTimeout(() => {
diff --git a/src/lib/integrations/meta/MetaBaseClient.ts b/src/lib/integrations/meta/MetaBaseClient.ts
index d74e4ce..11be238 100644
--- a/src/lib/integrations/meta/MetaBaseClient.ts
+++ b/src/lib/integrations/meta/MetaBaseClient.ts
@@ -133,7 +133,7 @@ export class MetaBaseClient {
 
     // Initial request
     const initialParams = { ...params, limit }
-    let response = await this.request<MetaPaginatedResponse<T>>(endpoint, {
+    const response = await this.request<MetaPaginatedResponse<T>>(endpoint, {
       params: initialParams,
     })